EXOSCALE: migrate to egoscale v3#4224
Open
natalie-o-perret wants to merge 1 commit intoDNSControl:mainfrom
Open
EXOSCALE: migrate to egoscale v3#4224natalie-o-perret wants to merge 1 commit intoDNSControl:mainfrom
natalie-o-perret wants to merge 1 commit intoDNSControl:mainfrom
Conversation
Author
7df8725 to
8c2b97f
Compare
pierre-emmanuelJ
approved these changes
May 4, 2026
8c2b97f to
e1b9d6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #3342 + bugfixes.
Changes from the original PR
v0.102.4)StackExchange->DNSControl,providers->pkg/providers)GetZoneRecordssignature:(dc *models.DomainConfig)instead of(string, map[string]string)Additional fixes found during testing
GetZoneRecordswas making oneGetDNSDomainRecordcall per record (N+1); the list response already includes full record data, so this is eliminated (was causing timeouts on zones with 100+ records)auditrecords.go: double-quotes, unpaired backslashes, empty strings (all cause idempotency diffs against the Exoscale API)Tests
Unit: 12/12 pass, see
exoscaleProvider_test.goIntegration: pass against a live Exoscale account (
TestDNSProviders, 350s), full log belowIntegration test log